Re: [BUG]: agpgart for i810 chipsets broken in 2.5.51

[Antonino Daplas]

On Tue, 2002-12-10 at 19:48, Dave Jones wrote:
> On Tue, Dec 10, 2002 at 09:47:24PM +0500, Antonino Daplas wrote:
>  > On Tue, 2002-12-10 at 18:11, Dave Jones wrote:
>  > > On Tue, Dec 10, 2002 at 05:21:29PM +0500, Antonino Daplas wrote:
>  > >  > 2.  The i810 driver for Xfree86 will also fail to load because of
>  > >  > version mismatch (0.99 vs 1.0).  Rolling back the version corrects the
>  > >  > problem.
>  > > 
>  > > Ugh, that's great. So X has to be patched every time the agpgart code
>  > > gets a new revision ? That sounds really unpleasant.
>  > > 
>  > Actually, X is complaining that the kernel version was too old, crazy
>  > no?
> 
> That chunk of X code is crap. So much so, that someone even put a
> comment there (not that what they suggested was much better).
> 
> See line 122 of http://www.atomised.org/docs/XFree86-4.2.1/agp_8c-source.html
> 
Ouch.  That's a sh??ty version check.  And it has to be present from
4.0.0 to 4.2.1, and if they don't correct it, 4.3.0.
 
Tony