Re: [BK-2.4] [PATCH] Small do_mmap_pgoff correction

David S. Miller (davem@redhat.com)
Tue, 10 Dec 2002 17:06:44 -0800 (PST)


From: DervishD <raul@pleyades.net>
Date: Tue, 10 Dec 2002 23:28:42 +0100

> How about something like:
>
> if (len == 0)
> return addr;
>
> len = PAGE_ALIGN(len);
> if (len > TASK_SIZE || len == 0)
> return -EINVAL;
>
> That should cover all cases and not make the TASK_SIZE assumption.

Perfect :) If you want, I can make the patch and tell to Alan and
Linus. Anyway, I think you will better heared than me O:))

If you could take care of this, I would really be happy.

Anyway, I'll take a look at a new macro (lets say PAGE_ALIGN_SIZE
or something as ugly as this ;)))

How many places do we try to apply PAGE_ALIGN to a length?
If it's just one or two spots, perhaps the special macro
isn't worthwhile.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/