Re: [BK][PATCH] ReiserFS CPU and memory bandwidth efficient large writes

Oleg Drokin (green@namesys.com)
Sat, 14 Dec 2002 22:20:53 +0300


Hello!

On Sat, Dec 14, 2002 at 10:42:38AM -0800, Andrew Morton wrote:
> > Find below the patch that address all the issues you've brought.
> > It is on top of previous one.
> > Do you think it is ok now?
> I addresses the things I noticed and raised, thanks. Except for the
> stack-space use. People are waving around 4k-stack patches, and we
> do need to be careful there.

Well, 450 bytes is way below 4k (~7 times less if we'd take task struct
into account) ;)
I can replace that on-stack array with kmalloc, but that probably
would be a lot of overhead for no benefit.
What do you think is safe stack usage limit for a function?
(and btw you have not even seen reiser4 stack usage ;) )

Bye,
Oleg
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/