Re: uml-patch-2.5.52-1

[William Lee Irwin III]

On Tue, Dec 17, 2002 at 07:54:00PM -0500, Jeff Dike wrote:
> This patch updates UML to 2.5.52.  As far as UML itself is concerned, this
> is identical to all recent 2.5 UML releases.
> The file corruption that I saw with the 2.5.50 UML seems to be gone; however
> Oleg Drokin is maintaining his own 2.5 UML repo, with forward ports of my 2.4
> updates, and he's reporting corruption with his 2.5.52.  I've exercised this
> patch with kernel builds and various other loads and seen no problem, so it's
> possible the problem is in his pool and not mine - however, caveat user.
> The 2.5.52 UML patch is available at
>         http://uml-pub.ists.dartmouth.edu/uml/uml-patch-2.5.52-1.bz2
> For the other UML mirrors and other downloads, see 
>         http://user-mode-linux.sourceforge.net/dl-sf.html

I have a pending patch against your tree. Could you review this, and if
it pass, include it in your tree?

Thanks,
Bill

get_task() really wants to do find_task_by_pid().
This calls find_task_by_pid() directly.

 process_kern.c |   10 ++--------
 1 files changed, 2 insertions(+), 8 deletions(-)

diff -urpN uml-2.5.52-1/arch/um/kernel/process_kern.c uml-2.5.52-2/arch/um/kernel/process_kern.c
--- uml-2.5.52-1/arch/um/kernel/process_kern.c	2002-12-17 19:54:03.000000000 -0800
+++ uml-2.5.52-2/arch/um/kernel/process_kern.c	2002-12-17 21:51:29.000000000 -0800
@@ -52,16 +52,10 @@ struct cpu_task cpu_tasks[NR_CPUS] = { [
 
 struct task_struct *get_task(int pid, int require)
 {
-        struct task_struct *task, *ret;
+        struct task_struct *ret;
 
-        ret = NULL;
         read_lock(&tasklist_lock);
-        for_each_process(task){
-                if(task->pid == pid){
-                        ret = task;
-                        break;
-                }
-        }
+	ret = find_task_by_pid(pid);
         read_unlock(&tasklist_lock);
         if(require && (ret == NULL)) panic("get_task couldn't find a task\n");
         return(ret);