Re: [PATCH] 2.5 fix link with fbcon built-in

Linus Torvalds (
Mon, 30 Dec 2002 12:03:24 -0800 (PST)

On 30 Dec 2002, Benjamin Herrenschmidt wrote:
> In current bk 2.5, drivers/video/console/fonts.c exports an
> init_module() symbol when built-in, which prevents the kernel from
> linking. Here's a quick fix.

This is not correct.

The functions should either be removed completely (preferred, since they
aren't even proper C syntax in the first place - since when do we put
semicolons at the end of a function?) or the file should be taught to use
proper "module_init()/module_exit()" semantics that work _correctly_ for
both modules and built-in.

The patch just hides just _how_ crap this file is, and as such should not
be applied. Crap doesn't get better from being hidden.


> +#ifdef MODULE
> int init_module(void) { return 0; };
> void cleanup_module(void) {};
> +#endif

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at