Re: [PATCH] 2.5 fix link with fbcon built-in
James Simmons (email@example.com)
Mon, 30 Dec 2002 21:30:06 +0000 (GMT)
> > This is not correct.
> > The functions should either be removed completely (preferred, since they
> > aren't even proper C syntax in the first place - since when do we put
> > semicolons at the end of a function?) or the file should be taught to use
> > proper "module_init()/module_exit()" semantics that work _correctly_ for
> > both modules and built-in.
> > The patch just hides just _how_ crap this file is, and as such should not
> > be applied. Crap doesn't get better from being hidden.
> Right, though weren't those empty functions just workarounds for a time
> where new module stuff didn't grok modules without module init/exit ? Is
> this still the case ? If not, then we should indeed just remove the
> function completely.
Correct. I added them while the module code was in a state of flux so it
would get it working. Now that the module code is stable what do we do?
I like to see those functions go away.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to firstname.lastname@example.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/