Re: 2.5.54 -- ohci-dbg.c: 358: In function `show_list': `data1'

[David Brownell]

Miles Lane wrote:
>   gcc -Wp,-MD,drivers/usb/host/.ohci-hcd.o.d -D__KERNEL__ -Iinclude -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2 -march=athlon -Iinclude/asm-i386/mach-default -fomit-frame-pointer -nostdinc -iwithprefix include    -DKBUILD_BASENAME=ohci_hcd
> -DKBUILD_MODNAME=ohci_hcd   -c -o drivers/usb/host/ohci-hcd.o drivers/usb/host/ohci-hcd.c
> In file included from drivers/usb/host/ohci-hcd.c:137:
> drivers/usb/host/ohci-dbg.c: In function `show_list':
> drivers/usb/host/ohci-dbg.c:358: `data1' undeclared (first use in this function)
> drivers/usb/host/ohci-dbg.c:358: (Each undeclared identifier is reported only once
> drivers/usb/host/ohci-dbg.c:358: for each function it appears in.)
> drivers/usb/host/ohci-dbg.c:358: `data0' undeclared (first use in this function)
> make[3]: *** [drivers/usb/host/ohci-hcd.o] Error 1

Looks like Greg's patch to use more dev_*() debug macros changed
some conditional structures too ... so the sysfs debug files are
always compiled in, rather than only with CONFIG_USB_DEBUG which
is what defines them.

Workaround by enabling USB debugging in your configuration.

I'll send some patch around later, likely to just revert that
part of his patch since I actually like having "production"
OHCI modules be less than 12K.  Though maybe those files should
be enabled with some other Kconfig option.  Thoughts?

- Dave