Re: Another idea for simplifying locking in kernel/module.c

Rusty Russell (rusty@rustcorp.com.au)
Sat, 11 Jan 2003 14:53:23 +1100


In message <200301101116.DAA03752@baldur.yggdrasil.com> you write:
> I wrote:
> >On Thu, 09 Jan 2003, Max Krasnyansky wrote:
> >>We have to be able to call try_module_get() from interrupt context.
>
> > Where? Why? Please show me one or more examples.
>
> Come to think of it, I don't think you even have to answer
> that question. You should be able to use my try_module_get() from
> interrupt context. It never blocks.

Yes, your try_module_get just gets spurious failures on SMP, as well
as thrashing the cacheline (why bother with one counter per CPU
then?).

I guess I just don't understand your solution?

Sorry,
Rusty.

--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/