Re: propagating failures down to pci_module_init()

Dave Jones (davej@codemonkey.org.uk)
Mon, 20 Jan 2003 16:56:38 +0000


On Mon, Jan 20, 2003 at 11:52:36AM -0500, Jeff Garzik wrote:
>
> Nope. Look at pci_module_init code. It propagates pci_register_driver
> return value.
>
> The _real_ problem is that ->probe return value is not propagated back
> to pci_register_driver return value. The reason for this is that you
> may call ->probe many times, and nobody has written the code to collate
> the error returns.
>
> Since one can only sanely return an error code when there was _one_
> device and it failed, you are rather limited in error propagation.

*nod*. I cheated, and used a static global, which seems to get the
desired effect I was after.

Dave

-- 
| Dave Jones.        http://www.codemonkey.org.uk
| SuSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/