Re: [PATCH][2.5] smp_call_function_mask

[Manfred Spraul]

Alan wrote:

>On Fri, 2003-01-17 at 05:18, Zwane Mwaikambo wrote:
>> +	/* Wait for response */
>> +	while (atomic_read(&data.started) != num_cpus)
>> +		barrier();
>
>Only old old intel x86 that does -bad- things as it
>generates a lot of bus locked cycles. Better to do
>
>	while(atomic_read(&data.started) != num_cpus)
>		while(data.started.value != num_cpus)
>		{
>			barrier();
>			cpu_relax();
>		}
>
>I would think ?
>
>  
>
from 2.5.52, <asm-i386/atomic.h>
    #define atomic_read(v)          ((v)->counter)
AFAIK atomic_read never contained locked bus cycles.

Btw, Zwane, what about removing non_atomic from the prototype?

--
    Manfred