ugh.
> [Insert lecture on dangers of using goto for unwind :-]
Actually, I rather don't like the practice of:
*errp = -EFOO;
<200 lines of code>
if (something_bad)
goto out;
And lo, both ext2_new_block() and ext3_new_block() have additional
bugs, due mainly to this dubious optimisation.
I'll change them to the very straightforward
if (something_bad) {
*errp = -EFOO;
goto out;
}
Thanks.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/