Re: [PATCH] irq handling code consolidation (v850 part)

[Miles Bader]

This is a MIME-formatted message.  If you see this text it means that your
E-mail software does not support MIME-formatted messages.

--=_courier-10384-1043215491-0001-2
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 7bit

Andrey Panin <[e-mail]> writes:
> This patch contains v850 specific changes for irq handling 
> code consolidation. Totally untested.

Works fine for me, with a small change:

--=_courier-10384-1043215491-0001-2
Content-Type: text/x-patch; charset=iso-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
  filename=irq-merge-v850-2.5.59-upd.patch
Content-Description: Update for patch-irq-v850-2.5.59

diff -up linux-2.5.59-uc0/arch/v850/kernel/irq.c.~1~ linux-2.5.59-uc0/arch/v850/kernel/irq.c
--- linux-2.5.59-uc0/arch/v850/kernel/irq.c.~1~	2003-01-22 14:25:01.000000000 +0900
+++ linux-2.5.59-uc0/arch/v850/kernel/irq.c	2003-01-22 14:40:30.000000000 +0900
@@ -1,8 +1,8 @@
 /*
  * arch/v850/kernel/irq.c -- High-level interrupt handling
  *
- *  Copyright (C) 2001,02  NEC Corporation
- *  Copyright (C) 2001,02  Miles Bader <[e-mail]>
+ *  Copyright (C) 2001,02,03  NEC Electronics Corporation
+ *  Copyright (C) 2001,02,03  Miles Bader <[e-mail]>
  *  Copyright (C) 1994-2000  Ralf Baechle
  *  Copyright (C) 1992  Linus Torvalds
  *
@@ -25,7 +25,7 @@
 
 #include <asm/system.h>
 
-volatile unsigned long spurious_count;
+extern atomic_t irq_err_count;
 
 /*
  * Generic, controller-independent functions:
@@ -71,7 +71,7 @@ int show_interrupts(struct seq_file *p, 
 			seq_printf(p, ", %s", action->name);
 		seq_putc(p, '\n');
 	}
-	seq_printf(p, "ERR: %10lu\n", irq_err_count);
+	seq_printf(p, "ERR: %10d\n", atomic_read(&irq_err_count));
 	return 0;
 }
 

--=_courier-10384-1043215491-0001-2
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 7bit

[Can someone pick this up?  It seems like a nice straight-forward
cleanup that doesn't change any functionality, and deletes a buttload of
duplicated code.]

-Miles
-- 
Fast, small, soon; pick any 2.

--=_courier-10384-1043215491-0001-2--