Re: Simple patches for Linux as a guest OS in a plex86 VM (please consider)

[Ingo Oeser]

On Wed, Jan 22, 2003 at 10:23:41AM -0800, Kevin Lawton wrote:
> For this, there's a few critical but simple diffs to
> macro'ize the use of the PUSHF and POPF instructions,
> due to broken semantics of running stuff using
> PVI (protected mode virtual interrupts).  The rest of
> the stuff I believe can be monitored effectively by
> the VM monitor.

Yes, what you do is nice, but generates much code. What about
this for pushfl:

pushfl
push %eax
pushfl
pop %eax
orb $(1<<1),%ah  /* same as orl $(1<<9),%eax */
testl $(1<<19),%eax
jnz 69001f
andb $~(1<<1),%ah /* same as andl $~(1<<9),%eax */
69001:
mov %eax,4(%esp)
pop %eax

? This saves 6 bytes, which is a 20% code reduction ;-)

Regards

Ingo Oeser
-- 
Science is what we can tell a computer. Art is everything else. --- D.E.Knuth