Re: copy_from_user broken on i386 since 2.5.57

[Mike Galbraith]

At 06:22 PM 1/23/2003 -0500, Bill Davidsen wrote:
>On Wed, 22 Jan 2003, Andrew Morton wrote:
>
> > Brice Goglin <[e-mail]> wrote:
> > >
> > > Hi,
> > >
> > > Trying to compile a very very simple module for 2.5,
> > > I got an error from gcc saying that assembly code
> > > is incorrect.
> > > This problem appeared in 2.5.57 and is still here
> > > in 2.5.59.
> > > I only tried on i386.
> > >
> > > Here's a very simple example code :
> > >
> > > #define __KERNEL__
> > > #define MODULE
> > > #include "linux/module.h"
> > > #include "asm/uaccess.h"
> > >
> > > int func(void *to, const void *from) {
> > >   return __copy_from_user(to, from, 1);
> > > }
> > >
> > >
> > > Here's gcc report :
> > >
> > > mp760:~/tmp% gcc user.c -c -o user.o -Ipath_to_2.5.57/include
> > > /tmp/cceAbcRd.s: Assembler messages:
> > > /tmp/cceAbcRd.s:120: Error: `%al' not allowed with `movl'
> > > /tmp/cceAbcRd.s:124: Error: `%al' not allowed with `xorl'
> > > /tmp/cceAbcRd.s:209: Warning: using `%eax' instead of `%ax' due to 
> `l' suffix
> > > /tmp/cceAbcRd.s:213: Warning: using `%eax' instead of `%ax' due to 
> `l' suffix
> > > /tmp/cceAbcRd.s:213: Warning: using `%eax' instead of `%ax' due to 
> `l' suffix
> >
> > Add `-O2' to the compiler switches.
> >
> > No, I don't know either ;)
>
>So, does this actually fix the problem or simply optimize the suspect code
>out of existance until some later date?

Compiler bug?  With -O2, gcc-2.95.3 emits movb and xorb at the same spot.

gcc-3.2.1 doesn't have a problem with that code optimized or not... it flat 
refuses to suck up any inline assembly unless you use at least -O 
-finline-limit=1580.  (why 1580?)

         -Mike