Re: [patch 2.5] pci_{save,restore}_extended_state

[Matthew Wilcox]

On Fri, Jan 24, 2003 at 09:24:03PM +0300, Ivan Kokshaysky wrote:
> pci.h: added missing SIZEOFs for each capability as per PCI specs.
> I'm not 100% sure about PCI_CHSWP_SIZEOF and PCI_X_SIZEOF - somebody
> with respective specs in hands (Matthew?) ought to verify this...

PCI-X is 8 bytes -- ID, Next capability, 2-byte `Command', 4-byte `Status'

Except PCI-X bridges, which are 16-bytes long.  And I didn't write down the
definition for those.

Hotswap uses only 3 bytes, but the 4th byte is `reserved' so better save
4 bytes rather than 3.

>  #define  PCI_CHSWP_PI		0x30	/* Programming Interface */
>  #define  PCI_CHSWP_EXT		0x40	/* ENUM# status - extraction */
>  #define  PCI_CHSWP_INS		0x80	/* ENUM# status - insertion */
> +#define PCI_CHSWP_SIZEOF	4
>  
>  /* PCI-X registers */
>  
> @@ -309,6 +314,7 @@
>  #define  PCI_X_STATUS_MAX_SPLIT	0x0380	/* Design Max Outstanding Split Trans */
>  #define  PCI_X_STATUS_MAX_CUM	0x1c00	/* Designed Max Cumulative Read Size */
>  #define  PCI_X_STATUS_SPL_ERR	0x2000	/* Rcvd Split Completion Error Msg */
> +#define PCI_X_SIZEOF		9
>  
>  /* Include the ID list */
>  

-- 
"It's not Hollywood.  War is real, war is primarily not about defeat or
victory, it is about death.  I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk