Re: [PATCH] 2.5.59 : drivers/net/fc/iph5526.c

--==_Exmh_-990700808P
Content-Type: text/plain; charset=us-ascii

On Mon, 10 Feb 2003 14:01:13 +0100, Horst von Brand said:
> Rusty Russell <[e-mail]> said:
> 
> [...]
> 
> > > -	for (i = 0; i < clone_list[i].vendor_id != 0; i++)
> 
> i < clone_list[i].vendor_id != 0 is (i < clone_list[i].vendor_id) != 0 is
> just i < clone_list[i].vendor_id, so the for is done for i = 0 and possibly
> for 1. Getting this effect (if desired) with an if is a load clearer.

However, looking at the definition of clone_list[], it's pretty obvious
that this was intended:

    for (i=0; clone_list[i].vendor_id != 0; i++) {...

It's searching through a zero-terminated table of vendor_id's.

It's possible it started off life as
     i < sizeof(clone_list) && clone_list[i].vendor_id != 0

or some such.  
-- 
				Valdis Kletnieks
				Computer Systems Senior Engineer
				Virginia Tech

--==_Exmh_-990700808P
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
Comment: Exmh version 2.5 07/13/2001

iD8DBQE+SHmccC3lWbTT17ARArCmAJ40SoREERsBG+ZlERr/d+QmX3G1xgCg0AOc
rr3fyyyVfvIJnx9ceHHMBqU=
=MccP
-----END PGP SIGNATURE-----

--==_Exmh_-990700808P--