Re: Fix random memory corruption during suspend-to-RAM resume

[Linus Torvalds]

On Tue, 11 Feb 2003, Pavel Machek wrote:
> > 
> > Hmm.. The stack grows downwards, are you sure you don't really mean
> > 
> > 	mov $(wakeup_end-wakeup_code),%sp
> > 
> > (because wakeup_end is the end of the wakeup_stack area..)
> 
> Yes, I'm sure:

No. The code is crap. Please send a _fixed_ patch that clearly puts the 
stack pointer at the _end_ of the stack.

What you are sure of is that is _happens_ to work by pure luck.

I'd rather have known-broken code in the kernel than code that works by 
mistake. The former at least gets fixed.

		Linus