Re: [PATCH] fix scsi/aha15*.c for 2.5.60

James Bottomley (James.Bottomley@steeleye.com)
13 Feb 2003 09:10:24 -0500


On Wed, 2003-02-12 at 18:31, Christoph Hellwig wrote:
> On Wed, Feb 12, 2003 at 05:44:24PM -0500, James Bottomley wrote:
> > > this gives these modules in /lib/modules/2.5.60/kernel/drivers/scsi/:
> > > aha152x.ko scsi_mod.ko sg.ko
> > >
> > > what am i missing??
> >
> > Nothing really, the symbols need to be exported from the SCSI core.
> > I'll add them to the export list.
>
> it should _not_ be exported. drivers are supposed to use the
> request-based interface instead.

Yes, if they issue commands via the mid-layer. This one is queueing a
message (encapsulated as a pseudo command) on it's internal queue (which
is a cmd queue) to issue a bus device reset. In this instance, it
cannot use the request based interface because the device will be
in_recovery when this happens, so it would never be issued.

Personally, it would be nice to have a messaging interface to get around
these problems, but I don't think that one's coming any time soon...

James

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/