Re: [PATCH] Extended attribute fixes, etc.

[Christoph Hellwig]

On Sat, Feb 15, 2003 at 06:59:11PM +0100, Andreas Gruenbacher wrote:
> > Please don't do the ugly flags stuff.  We have fsuids and fsgids for
> > exactly that reason (and because we're still lacking a credentials
> > cache..).
> 
> The XATTR_KERNEL_CONTEXT flag cannot be substituted by a uid/gid change; 
> it is unrelated to that; that's the whole point of it. It would be 
> possible to raise some other flag (such as a capability, etc.) instead 
> of passing an explicit flag, but that seems uglier and more 
> problematic/error prone to me.

Then raise CAP_DAC_OVERRIDE.  The right thing would be to pass down a
struct cred, so we could pass down the magic sys_cred that allows all
access (look at the XFS ACL code for details on that..), but
unfortuantately we still don't have proper credentials although there
were numerous patches around in the last years and we really want it
for other reasons.

Magic flags that change the DAC checks work are ugly and will most
certainly lead to bugs in some implementations sooner or later.