Re: anticipation is killing me

[Nick Piggin]

Hugh Dickins wrote:

>With 2.5.62-mm3 (not -mm2) I need small patch to can_start_anticipation.
>I've not studied the code, this patch may be the worst nonsense; and if
>it's at all mysterious to you, sorry, I probably won't be able to give
>more info until tomorrow...
>
>Hugh
>
>--- 2.5.62-mm3/drivers/block/as-iosched.c	Mon Feb 24 12:29:49 2003
>+++ linux/drivers/block/as-iosched.c	Mon Feb 24 21:38:39 2003
>@@ -856,7 +856,8 @@
> 		 */
> 		del_timer(&ad->antic_timer);
> 		ad->antic_status = ANTIC_FINISHED;
>-		blk_remove_plug(arq->request->q);
>+		if (arq)
>+			blk_remove_plug(arq->request->q);
> 		schedule_work(&ad->antic_work);
> 		return 0;
> 	}
>
No that makes sense. We want to remove the plug even if
arq is null however so I'll have to pass it in I suppose.