Re: [PATCH][ATM] make atm (and clip) modular + try_module_get()

David S. Miller (davem@redhat.com)
Wed, 05 Mar 2003 06:53:41 -0800 (PST)


From: chas williams <chas@locutus.cmf.nrl.navy.mil>
Date: Wed, 05 Mar 2003 10:08:42 -0500

In message <20030305.063158.53514369.davem@redhat.com>,"David S. Miller" writes
:
>If you own both objects, why lock anything?

i believe the original intent was to prevent anyone else from
appending to either of the lists while the lists are being joined.
while it would be slightly less efficient, should it use the
skb primitives? this is quite a bit easier to read:

I understand why you think you have to lock, that isn't the issue.

I'm telling you that you should be locking this crap at a much
higher level.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/