Re: [PATCH][ATM] make atm (and clip) modular + try_module_get()

[Kai Germaschewski]

On Wed, 5 Mar 2003, chas williams wrote:

> shocking!  so how about this then:
> 
> atm-y   := addr.o pvc.o signaling.o svc.o common.o atm_misc.o raw.o resources.o
> mpoa-y  := mpc.o mpoa_caches.o mpoa_proc.o
> 
> obj-$(CONFIG_ATM) += atm.o
> atm-$(CONFIG_PROC_FS) += proc.o
> atm-$(subst m,y,$(CONFIG_ATM_CLIP)) += ipcommon.o
> atm-$(subst m,y,$(CONFIG_NET_SCH_ATM)) += ipcommon.o
> obj-$(CONFIG_ATM_CLIP) += clip.o
> obj-$(CONFIG_ATM_LANE) += lec.o
> obj-$(CONFIG_ATM_MPOA) += mpoa.o
> obj-$(CONFIG_PPPOATM) += pppoatm.o

Better, but I still think you should group the statements which define 
what atm.o is composed of, i.e. move the atm-$... up, or the atm-y down ;)

It's up to you, though, of course.

--Kai