Re: [2.5] memleak in load_elf_binary?

Andrew Morton (
Fri, 7 Mar 2003 03:25:32 -0800

Oleg Drokin <> wrote:
> Hello!
> I am still playing with improving memleak detector thing from smatch project.
> Seems there is a memleak in fs/binfmt_elf.c::load_elf_binary() in current 2.5
> If setup_arg_pages() fails (line 638 in my sources) we do return but
> not freeing possibly allocated elf_interpreter (line 520) and
> allocated elf_phdata (line 500) areas.
> Is this looking real? At least it looks real for me (I am trying to get
> number of false positives way down).

Yes, you're right. And there's a second one further down.

Whoever thought of permitting more than one `return' statement in a C
function should be shot.

This needs a little thought, as we've already set the new personality and the
old executable has been rubbed out.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at