Re: [PATCH] register_blkdev

Andries.Brouwer@cwi.nl
Sat, 8 Mar 2003 01:57:00 +0100 (MET)


> social issues, that probably need to be answered first

Why worry? Why first?

Here are patches that go in the right direction, as
everybody agrees, I think.
So far Linus has taken my recent dev_t related patches
(even though the last two did not appear under my name).

I don't think anybody is willing to commit himself blindly
to unseen patches.

> a lot of drivers have static arrays where they just "know" that
> there can't be more than 256 minors under their control.

That does not matter so much.

There is the matter of correctness and the matter of power.
I worry most about correctness.

So my first job is to make sure that no bad minor is ever used
as array index. Fortunately registration is not by major but
by dev_t interval, so things tend to be correct automatically.

That is the audit-for-correctness part. Then there is the
power part. If a driver wants to handle many minors, it
can register a large range, or several ranges, possibly
dynamically. These changes are done on a driver-by-driver basis,
and need not be done before the type of dev_t is switched.

Andries
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/