Re: PCI driver module unload race?

Greg KH (greg@kroah.com)
Mon, 10 Mar 2003 15:51:31 -0800


On Tue, Mar 11, 2003 at 12:48:43AM +0100, Oliver Neukum wrote:
>
> > diff -Nru a/drivers/base/bus.c b/drivers/base/bus.c
> > --- a/drivers/base/bus.c Mon Mar 10 13:52:15 2003
> > +++ b/drivers/base/bus.c Mon Mar 10 13:52:15 2003
> > @@ -263,14 +263,25 @@
> > if (dev->bus->match(dev,drv)) {
> > dev->driver = drv;
> > if (drv->probe) {
> > - if ((error = drv->probe(dev))) {
>
> It seems that the semaphore in bus_add_device() makes this unnecessary.

Hm, yes. I think you are correct.

So this patch is not needed, and the struct module * can be ripped out
of struct usb_driver too :)

Thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/