[2.5] nfsd/export.c memleak.

Oleg Drokin (green@namesys.com)
Tue, 11 Mar 2003 17:58:48 +0300


Hello!

There is trivial memleak on error exit path in nfsd.
See the patch below.
Found with help of smatch + enhanced unfree script.

Bye,
Oleg

===== fs/nfsd/export.c 1.71 vs edited =====
--- 1.71/fs/nfsd/export.c Tue Feb 25 13:08:50 2003
+++ edited/fs/nfsd/export.c Tue Mar 11 17:55:18 2003
@@ -294,7 +294,10 @@

/* client */
len = qword_get(&mesg, buf, PAGE_SIZE);
- if (len <= 0) return -EINVAL;
+ if (len <= 0) {
+ err = -EINVAL;
+ goto out;
+ }
err = -ENOENT;
dom = auth_domain_find(buf);
if (!dom)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/