Re: [PATCH] remove BKL from ext2's readdir

Andrew Morton (akpm@digeo.com)
Sat, 15 Mar 2003 12:11:25 -0800


Alex Tomas <bzzz@tmi.comex.ru> wrote:
>
> >>>>> Andrew Morton (AM) writes:
>
> AM> hm, no. lseek is using the directory's i_sem now, and readdir
> AM> runs under that too. So we should be able to remove
> AM> lock_kernel() from the readdir implementation of all filesystems
> AM> which are using generic_file_llseek().
>
> looks like only coda and ntfs use generic_file_llseek(). other use
> default_llseek(). what's the reason do not use generic_file_llseek().
> historical only? or not?

grep again.

I've made the change to ext2 and ext3. Other filesystems will require
some thought to verify that the lock_kernel()s are not protecting
against some other random codepath.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/