Re: [PATCH] Don't refill pcp lists during SWSUSP.

Andrew Morton (akpm@digeo.com)
Mon, 17 Mar 2003 16:05:56 -0800


Nigel Cunningham <ncunningham@clear.net.nz> wrote:
>
> +extern unsigned int suspend_task;

Please do:

#ifdef CONFIG_SOFTWARE_SUSPEND
unsigned int suspend_task;
#else
#define suspend_task 0
#endif

so the compiler can remove the few fast-path instructions which you have
added.

>
> + suspend_task = current->pid;
> +

Zero is a valid PID (the idle task...). It might be clearer to make
suspend_task a task_struct*.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/