> > > This converts apic code to use driver model. It is neccessary for S3
> > > when you are using apic.
> >
> > Seems to be missing something.
> >
> > arch/i386/kernel/apm.c: In function `suspend':
> > arch/i386/kernel/apm.c:1242: warning: implicit declaration of function `device_suspend'
> > arch/i386/kernel/apm.c:1242: `SUSPEND_POWER_DOWN' undeclared (first use in this function)
> > arch/i386/kernel/apm.c:1242: (Each undeclared identifier is reported only once
> > arch/i386/kernel/apm.c:1242: for each function it appears in.)
> > arch/i386/kernel/apm.c:1264: warning: implicit declaration of function `device_resume'
> > arch/i386/kernel/apm.c:1264: `RESUME_POWER_ON' undeclared (first use in this function)
> > arch/i386/kernel/apm.c: In function `check_events':
> > arch/i386/kernel/apm.c:1378: `RESUME_POWER_ON' undeclared (first use in this function)
>
> Try this patch instead. This is my merge of my and Pavel's earlier
> patches, so it differs from Pavel's in some details.
> My patch works with APM -- I can do repeated synchronous and
> asynchronous suspends with it.
> I haven't tested oprofile. There are some issues wrt oprofile's
> interface with the local-APIC NMI watchdog. Pavel suggested one
> (IMHO ugly) workaround, I and John suggested another (viz, an
> enable/disable API with one bit of history). My patch implements
> that API.
Yes this looks nice, too. Linus please apply one of them, probably
Mikael's since he has worked on this code before.
Pavel
-- Horseback riding is like software... ...vgf orggre jura vgf serr. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/