[patch 2.5.65] ehci-hcd, don't use PCI MWI

David Brownell (david-b@pacbell.net)
Wed, 19 Mar 2003 07:21:42 -0800


This is a MIME-formatted message. If you see this text it means that your
E-mail software does not support MIME-formatted messages.

--=_courier-6624-1048087911-0001-2
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

Some users have been sending init logs for Athlon kernels that
include PCI warning messages about the PCI cache line size
getting set incorrectly ... where the kernel thinks that the
right value is 16 bytes. Since 64 bytes is the right number,
it's dangerous to enable MWI on such systems.

This patch stops trying to use MWI; it's a workaround for the
misbehavior of that PCI cacheline-setting code. Please apply
to 2.5 and 2.4 trees.

- Dave

--=_courier-6624-1048087911-0001-2
Content-Type: text/plain; name="ehci-0319a.patch"; charset=iso-8859-1
Content-Transfer-Encoding: 7bit
Content-disposition: inline; filename=ehci-0319a.patch

--- 1.45/drivers/usb/host/ehci-hcd.c Mon Feb 24 03:30:38 2003
+++ edited/drivers/usb/host/ehci-hcd.c Wed Mar 19 07:05:33 2003
@@ -432,7 +432,11 @@
}

/* help hc dma work well with cachelines */
- pci_set_mwi (ehci->hcd.pdev);
+ /* NOTE: disabled until it works reliably ... some x86/Athlon
+ * kernels are thinking 16 byte cachelines, not 64 byte ones,
+ * so clearly the MWI prep logic is wrong.
+ */
+ // pci_set_mwi (ehci->hcd.pdev);

/* clear interrupt enables, set irq latency */
temp = readl (&ehci->regs->command) & 0xff;

--=_courier-6624-1048087911-0001-2--