Re: [PATCH] reduce stack usage in arch/sh/kernel/pci-sh7751
Bob Miller (rem@osdl.org)
Thu, 20 Mar 2003 14:06:51 -0800
On Thu, Mar 20, 2003 at 01:59:11PM -0800, Bob Miller wrote:
> On Thu, Mar 20, 2003 at 12:08:33PM -0800, Randy.Dunlap wrote:
> > +
> > + bus = kmalloc(sizeof(*bus), GFP_ATOMIC);
> > + dev = kmalloc(sizeof(*dev), GFP_ATOMIC);
> > + if (!bus || !dev) {
> > + printk(KERN_ERR "Out of memory in %s\n", __FUNCTION__);
> > + goto exit;
> > + }
> > +
> If the kmalloc() for bus succeeds but for dev fails this will leak the
> memory given to bus.
>
That's a goto, not a return... Never mind.
--
Bob Miller Email: rem@osdl.org
Open Source Development Lab Phone: 503.626.2455 Ext. 17
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/