Re: [PATCH] reduce stack in cdrom/optcd.c

Arjan van de Ven (arjanv@redhat.com)
22 Mar 2003 21:19:59 +0100


This is a MIME-formatted message. If you see this text it means that your
E-mail software does not support MIME-formatted messages.

--=_courier-29125-1048364547-0001-2
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Sat, 2003-03-22 at 21:43, Alan Cox wrote:
> On Sat, 2003-03-22 at 06:51, Randy.Dunlap wrote:
> > Hi,
> >=20
> > This reduces stack usage in drivers/cdrom/optcd.c by
> > dynamically allocating a large (> 2 KB) buffer.
> >=20
> > Patch is to 2.5.65. Please apply.
>=20
> This loosk broken. You are using GFP_KERNEL memory allocations on the
> read path of a block device. What happens if the allocation fails=20
> because we need memory

it's unlikely that you have your swap on the cdrom ;)

--=_courier-29125-1048364547-0001-2
Content-Type: application/pgp-signature; name="signature.asc"
Content-Transfer-Encoding: 7bit
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQA+fMVuxULwo51rQBIRAvsDAJ0TKftjOjsSlEYtS0yRc6Gtpn4d0ACffVRW
o/CvqmvN+0ZGZWeoNnHS034=
=06Zi
-----END PGP SIGNATURE-----

--=_courier-29125-1048364547-0001-2--