--=_courier-21482-1048370691-0001-2
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
On Sat, 22 Mar 2003, Dominik Brodowski wrote:
> On Sat, Mar 22, 2003 at 04:35:05PM +0000, Alan Cox wrote:
> >
> > I've seen 3 or 4 reports of this, none of them duplicatable with the same IDE
> > code on 2.4 so far. Which is odd but I don't yet understand what is going on.
> /me neither, unfortunately :-(
Alan, I can trigger the same dma_intr bug under 2.4.21-pre5-ac3 but not
2.4.20-ac2 (VIA vt8235 + WD800JB so it is not controller/disk related).
Dominik could you try attached patch with vanilla 2.5.65?
It reverts previous logic of handling masked_irq argument of ide_do_request().
Previously callers called it with masked_irq=0 and disabling/enabling
hwif->irq code wasn't executed, now ide_do_request() is called with
masked_irq=IDE_NO_IRQ=-1 so this code is executed for sure.
And no, I don't know wtf is exactly going on there :\.
[ Alan, please forget about yesterday's mail, I hitted dma_intr again today
with yesterday's patch, with attached patch I hope it is gone now :-) ]
BTW 2.5.64-ac4 deadlocks for me the same way Dominik has described.
Greets
-- Bartlomiej--=_courier-21482-1048370691-0001-2 Content-Type: text/plain; charset=us-ascii; name="2.5.65-dma_intr-fix.diff" Content-Transfer-Encoding: base64 Content-ID: <Pine.SOL.4.30.0303222303330.23357@mion.elka.pw.edu.pl> Content-Description: Content-Disposition: attachment; filename="2.5.65-dma_intr-fix.diff"
LS0tIGxpbnV4LTIuNS42NS9kcml2ZXJzL2lkZS9pZGUtaW8uYwlGcmkgTWFy IDIxIDE0OjI0OjMxIDIwMDMNCisrKyBsaW51eC1kbWFfaW50ci1maXgvZHJp dmVycy9pZGUvaWRlLWlvLmMJU2F0IE1hciAyMiAyMjowMzoyNiAyMDAzDQpA QCAtODM4LDE0ICs4MzgsMTQgQEANCiAJCSAqIGhhcHBlbnMgYW55d2F5IHdo ZW4gYW55IGludGVycnVwdCBjb21lcyBpbiwgSURFIG9yIG90aGVyd2lzZQ0K IAkJICogIC0tIHRoZSBrZXJuZWwgbWFza3MgdGhlIElSUSB3aGlsZSBpdCBp cyBiZWluZyBoYW5kbGVkLg0KIAkJICovDQotCQlpZiAoaHdpZi0+aXJxICE9 IG1hc2tlZF9pcnEpDQorCQlpZiAobWFza2VkX2lycSAmJiBod2lmLT5pcnEg IT0gbWFza2VkX2lycSkNCiAJCQlkaXNhYmxlX2lycV9ub3N5bmMoaHdpZi0+ aXJxKTsNCiAJCXNwaW5fdW5sb2NrKCZpZGVfbG9jayk7DQogCQlsb2NhbF9p cnFfZW5hYmxlKCk7DQogCQkJLyogYWxsb3cgb3RoZXIgSVJRcyB3aGlsZSB3 ZSBzdGFydCB0aGlzIHJlcXVlc3QgKi8NCiAJCXN0YXJ0c3RvcCA9IHN0YXJ0 X3JlcXVlc3QoZHJpdmUsIHJxKTsNCiAJCXNwaW5fbG9ja19pcnEoJmlkZV9s b2NrKTsNCi0JCWlmIChod2lmLT5pcnEgIT0gbWFza2VkX2lycSkNCisJCWlm IChtYXNrZWRfaXJxICYmIGh3aWYtPmlycSAhPSBtYXNrZWRfaXJxKQ0KIAkJ CWVuYWJsZV9pcnEoaHdpZi0+aXJxKTsNCiAJCWlmIChzdGFydHN0b3AgPT0g aWRlX3JlbGVhc2VkKQ0KIAkJCWdvdG8gcXVldWVfbmV4dDsNCkBAIC04NjEs NyArODYxLDcgQEANCiAgKi8NCiB2b2lkIGRvX2lkZV9yZXF1ZXN0KHJlcXVl c3RfcXVldWVfdCAqcSkNCiB7DQotCWlkZV9kb19yZXF1ZXN0KHEtPnF1ZXVl ZGF0YSwgSURFX05PX0lSUSk7DQorCWlkZV9kb19yZXF1ZXN0KHEtPnF1ZXVl ZGF0YSwgMCk7DQogfQ0KIA0KIC8qDQpAQCAtMTAwOSw3ICsxMDA5LDcgQEAN CiAJCQkJaHdncm91cC0+YnVzeSA9IDA7DQogCQl9DQogCX0NCi0JaWRlX2Rv X3JlcXVlc3QoaHdncm91cCwgSURFX05PX0lSUSk7DQorCWlkZV9kb19yZXF1 ZXN0KGh3Z3JvdXAsIDApOw0KIAlzcGluX3VubG9ja19pcnFyZXN0b3JlKCZp ZGVfbG9jaywgZmxhZ3MpOw0KIH0NCiANCkBAIC0xMjk5LDcgKzEyOTksNyBA QA0KIAkJaW5zZXJ0X2VuZCA9IDA7DQogCX0NCiAJX19lbHZfYWRkX3JlcXVl c3QoJmRyaXZlLT5xdWV1ZSwgcnEsIGluc2VydF9lbmQsIDApOw0KLQlpZGVf ZG9fcmVxdWVzdChod2dyb3VwLCBJREVfTk9fSVJRKTsNCisJaWRlX2RvX3Jl cXVlc3QoaHdncm91cCwgMCk7DQogCXNwaW5fdW5sb2NrX2lycXJlc3RvcmUo JmlkZV9sb2NrLCBmbGFncyk7DQogDQogCWVyciA9IDA7DQo= --=_courier-21482-1048370691-0001-2--