Re: 2.4+ptrace exploit fix breaks root's ability to strace

Russell King (rmk@arm.linux.org.uk)
Sun, 23 Mar 2003 10:38:54 +0000

On Sun, Mar 23, 2003 at 12:31:39PM +0200, Lists (lst) wrote:
> The patch breaks /proc/<pid>/cmdline and /proc/<pid>/environ for 'non
> dumpable' processes, even for root.

This fix is definitely wrong.

> - if (!is_dumpable(tsk) || (&init_mm == mm))
> + if ((!is_dumpable(tsk) || (&init_mm == mm)) && (current->uid != 0))
> mm = NULL;

Today, security is based around the capability system, not UID numbers.

-- 
Russell King (rmk@arm.linux.org.uk)                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/