Re: [PATCH 2.5.66] sychronize_net patch (1/2)

David S. Miller (davem@redhat.com)
Tue, 01 Apr 2003 09:51:53 -0800 (PST)


From: Stephen Hemminger <shemminger@osdl.org>
Date: 31 Mar 2003 15:12:58 -0800

@@ -2508,6 +2508,12 @@
return 0;
}

+/* Synchronize with packet receive processing. */
+void synchronize_net() {
+ br_write_lock_bh(BR_NETPROTO_LOCK);
+ br_write_unlock_bh(BR_NETPROTO_LOCK);
+}
+

Functions without arguments are specified with "(void)" not "()", I'm
surprised the compiler didn't warn you about this.

Also, bad code style:

void function_name(args)
{
}

Never like:

void function_name(args) {
}

Functions are not braced like conditional statements such as:

if (foo) {
}

or

while (foo) {
}

Please fix this stuff.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/