Re: [PATCH 2.5.66-mm2] Fix page_convert_anon locking issues

Dave McCracken (dmccr@us.ibm.com)
Wed, 02 Apr 2003 17:42:25 -0600


--On Wednesday, April 02, 2003 15:38:45 -0800 Andrew Morton
<akpm@digeo.com> wrote:

> But:
>
> + /* Double check to make sure the pte page hasn't been freed */
> + if (!pmd_present(*pmd))
> + goto out_unmap;
> +
> ==> munmap, pte page is freed, reallocated for pagecache, someone
> happens to write the correct value into it.
>
> + if (page_to_pfn(page) != pte_pfn(*pte))
> + goto out_unmap;
> +
> + if (addr)
> + *addr = address;
> +

Oops. The pmd_present() check should be after the page_to_pfn() !=
pte_pfn() check.

Dave

======================================================================
Dave McCracken IBM Linux Base Kernel Team 1-512-838-3059
dmccr@us.ibm.com T/L 678-3059

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/