Re: PATCH: Fixes for ide-disk.c

Alan Cox (alan@lxorguk.ukuu.org.uk)
06 Apr 2003 22:02:46 +0100


On Sul, 2003-04-06 at 21:59, Nigel Cunningham wrote:
> Ok. I just figured that if there are two (say) calls to suspend a
> driver, there should be two calls to resume it before it actually is
> resumed. Does the spec say anything about how multiple suspends &
> resumes should be handled?

The IDE layer assumes the power management layer doesn't generate
bogus repeated suspend requests. If it does then lots of drivers
are broken and the core code needs fixing.

If its because there are two different notifiers trying to park
the IDE disk that might make more sense.

However getting this wrong loses data so I will accept no changes to
this code until someone precisely explains what is going on so we
can be sure the fix itself is safe.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/