Re: [PATCH] remove kdevname() before someone starts using it again

Nikita Danilov (Nikita@Namesys.COM)
Mon, 7 Apr 2003 12:43:14 +0400


Christoph Hellwig writes:
> On Mon, Apr 07, 2003 at 11:43:01AM +0400, Nikita Danilov wrote:
> > Nicholas Wourms writes:
> > >
> > > A quick grep shows that Intermezzo FS still uses kdevname if
> > > you've turned on debugging (fs/intermezzo/sysctl.c). As for
> > > pending stuff, both Reiser4 & pktcdvd also use it. So I
> >
> > reiser4 switched to bdevname().
>
> Although bdevname is the simplest replacement it's usually the wrong
> one. If you refer to a filesystem with it use sb->s_id, if you refer
> to a block device you normally want to use partition_name() - it gives
> much nicer output.

Thank you for the information.

We need something to name per super block directory under
/sys/fs/reiser4. It probably makes sense to have a convention for this
shared by all file systems living on top of block devices, like using
sb->s_id.

>

Nikita.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/