Re: 2.5.67-mm1

Alistair Strachan (alistair@devzero.co.uk)
Wed, 9 Apr 2003 08:00:42 +0100


Hi,

On Wednesday 09 April 2003 00:06, Badari Pulavarty wrote:
> On Tuesday 08 April 2003 02:28 pm, Andrew Morton wrote:
> > Ah, good detective work, thanks. It looks like the hd_struct
> > dynamic allocation patch has broken devfs partition discovery
> > somehow.
>
> Thanks.. I am going to look now. Must have broken something in devfs.
>
> - Badari

Sorry for the delay, I've only just woken up. I applied the patch, it
wouldn't compile, you missed the following (I think obvious) chunk:

--- linux-2.5/fs/partitions/check.c.old 2003-04-09 07:49:29 +0100
+++ linux-2.5/fs/partitions/check.c 2003-04-09 07:51:26 +0100
@@ -160,7 +160,7 @@
{
#ifdef CONFIG_DEVFS_FS
devfs_handle_t dir;
- struct hd_struct *p = dev->part;
+ struct hd_struct **p = dev->part;
char devname[16];

if (p[part-1]->de)

With that in place, it compiled without warning and the machine now
boots with the dynamic hd_struct work + aggregate stats patch.

Thanks for your time.

Cheers,
Alistair.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/