Re: [PATCH][2.4] smp_call_function needs mb()

Zwane Mwaikambo (zwane@linuxpower.ca)
Fri, 11 Apr 2003 10:14:30 -0400 (EDT)


Oops i ended up including the 2.5 patch in the same email. This one should
be fine to pipe through patch.

Index: linux-2.4.20/arch/i386/kernel/smp.c
===================================================================
RCS file: /build/cvsroot/linux-2.4.20/arch/i386/kernel/smp.c,v
retrieving revision 1.2
diff -u -p -B -r1.2 smp.c
--- linux-2.4.20/arch/i386/kernel/smp.c 11 Apr 2003 13:44:11 -0000 1.2
+++ linux-2.4.20/arch/i386/kernel/smp.c 11 Apr 2003 13:44:27 -0000
@@ -563,7 +563,7 @@ int smp_call_function (void (*func) (voi

spin_lock(&call_lock);
call_data = &data;
- wmb();
+ mb();
/* Send a message to all other CPUs and wait for them to respond */
send_IPI_allbutself(CALL_FUNCTION_VECTOR);

-- 
function.linuxpower.ca
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/