Re: Oops: ptrace fix buggy

Martin Schlemmer (azarah@gentoo.org)
14 Apr 2003 20:10:25 +0200


This is a MIME-formatted message. If you see this text it means that your
E-mail software does not support MIME-formatted messages.

--=_courier-27667-1050345783-0001-2
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On Mon, 2003-04-14 at 16:47, J=F6rn Engel wrote:
> On Mon, 14 April 2003 16:31:08 +0200, Martin Schlemmer wrote:
> > On Mon, 2003-04-14 at 15:46, J=F6rn Engel wrote:
> >=20
> > > Privately, I have introduced a variable FIXLEVEL for this. The
> > > resulting kernel version is 2.4.20.2 instead of 2.4.20-uv2, which imo
> > > is more suiting for a fixed stable kernel.
> >=20
> > This is not a good idea ... especially if its a box that you
> > compile a lot of software on. Reason is that everything expects
> > it to be MAJ.MIN.MIC ... If you add now another version, then
> > things start to break. A good example is mozilla ...
>=20
> That doesn't convince me (yet?). Why doesn't 2.4.20-pre5-ac3 break
> mozilla, but 2.4.20.1 does? If mozilla depends on this information, it
> should at least have a robust parser for it.
>=20
> Can you give me a little more details on this? Did anyone ever declare
> that userspace can expect kernel versions to fit this regex?
> \d+\.\d+\.\d+(-.+)?
>=20

=46rom include/linux/version.h:

---------------------------------------------------------------
#define UTS_RELEASE "2.5.67-bk2"
#define LINUX_VERSION_CODE 132419
#define KERNEL_VERSION(a,b,c) (((a) << 16) + ((b) << 8) + (c))
---------------------------------------------------------------

Your changes will definitely break things that do:

#if ((LINUX_VERSION_CODE > KERNEL_VERSION(2.4.0)) && \
(LINUX_VERSION_CODE < KERNEL_VERSION(2.5.0)))

Also, most docs explaining the version format, refer to

major.minor.micro

Anyhow, I did not say it was set in stone, I just said if you
start getting breakage when compiling/configuring things, do
not wonder why =3D)

Regards,

--=20

Martin Schlemmer

--=_courier-27667-1050345783-0001-2
Content-Type: application/pgp-signature; name="signature.asc"
Content-Transfer-Encoding: 7bit
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQA+mvmRqburzKaJYLYRArZhAJ9/YuZDlw9v2tb6M1e03X54+x0fkACfWETa
QUY2QXippxvSPioSDtKjB2g=
=8502
-----END PGP SIGNATURE-----

--=_courier-27667-1050345783-0001-2--