Re: top stack (l)users for 2.5.67

Dave Jones (davej@codemonkey.org.uk)
Mon, 14 Apr 2003 19:25:53 +0100


On Mon, Apr 14, 2003 at 07:46:45PM +0200, J?rn Engel wrote:

> +/* FIXME: should the below go into some header file? */
> +#define PRESTO_COPY_KML_TAIL_BUFSIZE 4096
> struct file * presto_copy_kml_tail(struct presto_file_set *fset,
> unsigned long int start)
> {

so, presto_copy_kml_tail() is only called from
presto_finish_kml_truncate(), which doesn't seem to be called
from anywhere. What am I missing here? Or can this whole lot
just be nuked ?

If not, this patch introduces a problem. You're now
calling a sleeping function (kmalloc) whilst holding
a lock according to the comment above presto_finish_kml_truncate()

Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/