Re: [PATCH] More USB fixes for 2.5.67

Greg KH (greg@kroah.com)
Wed, 16 Apr 2003 23:05:04 -0700


ChangeSet 1.1056, 2003/04/14 10:17:46-07:00, greg@kroah.com

[PATCH] USB: fix up spin_unlock_irqrestore() issues in previous patch

diff -Nru a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
--- a/drivers/usb/core/hcd.c Wed Apr 16 10:49:33 2003
+++ b/drivers/usb/core/hcd.c Wed Apr 16 10:49:33 2003
@@ -1283,13 +1283,13 @@
if (urb->status != -EINPROGRESS)
continue;
usb_get_urb (urb);
- spin_unlock (&hcd_data_lock);
+ spin_unlock_irqrestore (&hcd_data_lock, flags);

- spin_lock (&urb->lock);
+ spin_lock_irqsave (&urb->lock, flags);
tmp = urb->status;
if (tmp == -EINPROGRESS)
urb->status = -ESHUTDOWN;
- spin_unlock (&urb->lock);
+ spin_unlock_irqrestore (&urb->lock, flags);

/* kick hcd unless it's already returning this */
if (tmp == -EINPROGRESS) {

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/