Re: PATCH: usb-uhci: interrupt out with urb->interval 0

Greg KH (greg@kroah.com)
Fri, 18 Apr 2003 00:05:14 -0700


On Thu, Apr 17, 2003 at 10:31:18AM +0200, Frode Isaksen wrote:
> A recent change (2.4.21)

Um, 2.4.21 is not out yet :)

> in the usb-uhci driver calls
> "uhci_clean_iso_step2" after the completion of one-shot (urb->interval
> 0) interrupt out transfers. This call clears the list of descriptors.
> However, it crashes when trying to get the next desciptor in the "for"
> loop in the "process_interrupt" function, since the list of descriptors
> are already cleared. A simple change I did was to do a "break" to quit
> the "for" loop for interrupt out transfers with urb->interval 0.

Hm, I thought someone tested this previously. Do you have a test case
for this that I can try to duplicate the problem for?

Also, your patch will not apply against the latest (2.4.21-pre7) version
of this file.

thanks,

greg k-h

p.s. I'd recommend sending these kinds of patches to the linux-usb-devel
mailing list too. That's where most of the Linux USB developers are.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/