Re: proposed optimization for network drivers

Don Cohen (don-linux@isis.cs3-inc.com)
Fri, 18 Apr 2003 09:22:50 -0700


David S. Miller writes:
> From: don-linux@isis.cs3-inc.com (Don Cohen)
> Date: Fri, 18 Apr 2003 08:37:01 -0700
>
> For instance, why does every driver have to call
> eth_type_trans? Could that be delayed for netif_rx ?
>
> Silly example. Ethernet specific routines do not belong in
> device generic netif_rx().

Ok, fair enough.
How about the larger point that it's reasonable to check early whether
the labor you're about to expend will be wasted and the suggestion
that this be encapsulated in a function that all drivers can share?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/