Re: Fix irq event debug print-out, and add stack dump which can

Muli Ben-Yehuda (mulix@mulix.org)
Tue, 22 Apr 2003 10:29:04 +0300


This is a MIME-formatted message. If you see this text it means that your
E-mail software does not support MIME-formatted messages.

--=_courier-26566-1050997887-0001-2
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 22, 2003 at 06:05:40AM +0000, Linux Kernel Mailing List wrote:

> printk(retval
> ? "irq event %d: bogus retval mask %x\n"
> : "irq %d: nobody cared!\n",
> irq,=20
> retval);

Uhm, the first printk string takes two parameters, and the second one=20
only one parameter... how about this cosmetic patch? Better some
superflous information than printk params mismatch. Not tested,
obvious.=20

diff -u -r1.31 irq.c
--- arch/i386/kernel/irq.c 21 Apr 2003 20:10:51 -0000 1.31
+++ arch/i386/kernel/irq.c 22 Apr 2003 06:31:10 -0000
@@ -225,7 +225,7 @@
count--;
printk(retval
? "irq event %d: bogus retval mask %x\n"
- : "irq %d: nobody cared!\n",
+ : "irq %d: nobody cared! (retval %x)\n",
irq,=20
retval);
}

--=20
Muli Ben-Yehuda
http://www.mulix.org

--=_courier-26566-1050997887-0001-2
Content-Type: application/pgp-signature
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE+pO8/KRs727/VN8sRAkKXAKCEbrSMcBvxwHNMsGV61ParVuMh6ACfYPYB
zeUnUofzK/NwerWNv0jW9rE=
=5Fnc
-----END PGP SIGNATURE-----

--=_courier-26566-1050997887-0001-2--