Re: [PATCH] aha1740 update

Christoph Hellwig (hch@infradead.org)
Thu, 24 Apr 2003 14:39:25 +0100


On Thu, Apr 24, 2003 at 03:34:25PM +0200, Marc Zyngier wrote:
> >>>>> "CH" == Christoph Hellwig <hch@infradead.org> writes:
>
> >> +/* This should really fit in driver/scsi/scsi.h, along with
> >> + * scsi_to_{pci,sbus}_dma_dir.... */
>
> CH> Right. Please submit a patch to James.
>
> I think this would cause some troubles. I would have to include
> linux/dma-mapping in driver/scsi/scsi.h, but many non-PCI
> architectures are still including asm-generic/dma-mapping.h, which has
> lots of references to PCI functions... I'm afraid this would clash
> badly on, say, sparc or m68k...

Then make it conditional on COFIG_EISA && CONFIG_MAC for now and
add a big FIXME. I'll break it at some point then, so I'll get
blamed instead of you :)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/