[PATCH] More USB fixes for 2.5.68

Greg KH (greg@kroah.com)
Thu, 24 Apr 2003 16:47:31 -0700


ChangeSet 1.1110.2.1, 2003/04/18 16:11:42-07:00, david-b@pacbell.net

[PATCH] USB: fix for deadlock in v2.5.67

The patch below should resolve the keyboard problem -- just reorders two
lines so the lock isn't held after the device's records get deleted, so
the order is what it should always have been.

drivers/usb/core/hcd.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)

diff -Nru a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
--- a/drivers/usb/core/hcd.c Thu Apr 24 16:29:16 2003
+++ b/drivers/usb/core/hcd.c Thu Apr 24 16:29:16 2003
@@ -961,8 +961,8 @@
spin_lock_irqsave (&hcd_data_lock, flags);
list_del_init (&urb->urb_list);
dev = urb->dev;
- usb_put_dev (dev);
spin_unlock_irqrestore (&hcd_data_lock, flags);
+ usb_put_dev (dev);
}


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/