Re: [RFC/PATCH] IDE Power Management try 1

Benjamin Herrenschmidt (benh@kernel.crashing.org)
25 Apr 2003 13:32:58 +0200


> What about this - add __REQ_DRIVE_INTERNAL, and carry args in
> rq->cmd[16] [0] = PM, [1] = SUSPEND/RESUME, [2]= STATE ? IDE can use it
> for power managment, error handling (do not do it from interrupt
> context, but queue it), may be more. This way it would really makes
> things a bit better with the complicated IDE locking. SCSI and probably
> other block devices can benefit from this internal requests too, so the
> bit is not wasted.

I agree. IDE locking isn't _that_ complicated ;) Though currently, we do
handle requests right on interrupt completion so error handling wouldn't
be deferred by this trick.

Jens, what do you think ? You are the blkdev.h guy :)

Ben.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/