--=_courier-6336-1051279547-0001-2
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
On Fri, 2003-04-25 at 00:12, mikem@beardog.cca.cpqcorp.net wrote:
> 20030424
>=20
> Changes:
> 1. Sets the DMA mask to 64 bits. Removes RH's code for the DMA mask.
>=20
> diff -urN lx2421rc1-p3/drivers/block/cciss.c lx2421rc1/drivers/block/ccis=
s.c
> --- lx2421rc1-p3/drivers/block/cciss.c Wed Apr 23 14:40:48 2003
> +++ lx2421rc1/drivers/block/cciss.c Wed Apr 23 14:51:55 2003
> @@ -106,7 +106,7 @@
> #define NR_CMDS 128 /* #commands that can be outstanding */
> #define MAX_CTLR 8
> =20
> -#define CCISS_DMA_MASK 0xFFFFFFFF /* 32 bit DMA */
> +#define CCISS_DMA_MASK 0xFFFFFFFFFFFFFFFF /* 64 bit DMA */
> =20
> static ctlr_info_t *hba[MAX_CTLR];
> =20
> @@ -2861,17 +2861,6 @@
> hba[i]->ctlr =3D i;
> hba[i]->pdev =3D pdev;
> =20
> - /* configure PCI DMA stuff */
> - if (!pci_set_dma_mask(pdev, (u64) 0xffffffffffffffff))
> - printk("cciss: using DAC cycles\n");
> - else if (!pci_set_dma_mask(pdev, (u64) 0xffffffff))
> - printk("cciss: not using DAC cycles\n");
> - else {
> - printk("cciss: no suitable DMA available\n");
> - free_hba(i);
> - return -ENODEV;
> - }
> - =09
this is wrong. The code there is EXACTLY what is needed as per
Documentation/DMA-mapping.txt, removing it is a bug.
--=_courier-6336-1051279547-0001-2
Content-Type: application/pgp-signature; name="signature.asc"
Content-Transfer-Encoding: 7bit
Content-Description: This is a digitally signed message part
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
iD8DBQA+qUBwxULwo51rQBIRAhlrAJ9Z2MYTFrKIeDyb5+R0UiBUAlBzEgCfbGmA
cZdYxpVjkqKcn5BeHpJ/fyo=
=rxi/
-----END PGP SIGNATURE-----
--=_courier-6336-1051279547-0001-2--